Analysis status does not update if routine does not call save_results

[philipstarkey]

Original report (archived issue) by Shaun Johnstone (Bitbucket: shjohnst, GitHub: shjohnst).

---

I've just noticed that some single shot analysis routines seem to get "skipped" by the status bar, e.g. if you have 4 running, in some cases the bar will go 0% > 25% > 75% >100%.

It appears as though the routines which are skipped do not call run.save_results(), for example, if using the following test script, the status bar will not update after the routine has finished, unless the last line is commented out.

#!python

from lyse import *
import time
run = Run(path)
time.sleep(3)
#run.save_results("key","value")

I suspect that this bug was introduced in pull request #17. It's only a minor cosmetic thing, but worth fixing at some point! This was first noticed on an OD calculating routine, run.save_result_array() is used, but not run.save_results().

[philipstarkey]

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

---

Thanks! I know why this is. Will fix.

[philipstarkey]

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

---

• changed state from "new" to "resolved"

Fixed issue #31: analysis status not updating if no saved results

→ \<\<cset b88dd9f5c9ee215be1e516665a5e59a22d7ca808>>

[philipstarkey]

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

---

Merged in cbillington/lyse/bugfix (pull request #28)

Fixed issue #31: analysis status not updating if no saved results

Approved-by: PhyNerd jan.wrk.fb@gmail.com Approved-by: Shaun Johnstone shaun.johnstone@monash.edu

→ \<\<cset d594f8a7d3e2eb3054ed67a4185a1a142209af2c>>