search

labscript-suite-temp-2 / lyse

lyse is an analysis framework. It coordinates the running of python analysis scripts on experiment data as it becomes availiable, updating plots in real time.
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Lyse freezes on selection #33

Closed philipstarkey closed 6 years ago

philipstarkey commented 7 years ago

Original report (archived issue) by Jan Werkmann (Bitbucket: PhyNerd, GitHub: PhyNerd).

If there are more than a few hundred (200 should be enough) shots loaded in lyse and one selects them all lyse will freeze or dramatically slow down when new shots come in during this time. This very commonly happens to us as we commonly forget to clear shots out of lyse inbetween sequences and when we want to delete the old ones lyse becomes unusable.

philipstarkey commented 7 years ago

Original comment by Jan Werkmann (Bitbucket: PhyNerd, GitHub: PhyNerd).

Found a solution: If we block all signals during update_row things run smoothly.

So I added this to the top of update_row:

#!python
self._model.blockSignals(True)

And this to the bottom of update_row:

#!python
        self._model.blockSignals(False)
        self._model.layoutChanged.emit()

I'm not sure if there are any downsides to this so I'll test a bit before creating a pull request.

philipstarkey commented 6 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

Fixed by pull request #37