labscript-suite-temp-2 / lyse

lyse is an analysis framework. It coordinates the running of python analysis scripts on experiment data as it becomes availiable, updating plots in real time.
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Text of row header is truncated #46

Closed philipstarkey closed 5 years ago

philipstarkey commented 5 years ago

Original report (archived issue) by Russell Anderson (Bitbucket: rpanderson, GitHub: rpanderson).

The original report had attachments: integer_indexing_False.png, integer_indexing_True.png


The vertical (row) header values are truncated, with either integer_indexing = False (default) or True in labconfig (see attachments). In the latter, only the last digit of the zero-padded run repeat integer is missing. I think the relevant setting for this element sizing is here, i.e. setSectionResizeMode(QtWidgets.QHeaderView.Fixed). I've tried changing Fixed to ResizeToContents and Interactive, but these appear to not be honoured. For example, when using Interactive, adjustment of the vertical header width is possible before adding any shots to lyse, but disappears once shots are added. Maybe use setMinimumWidth for the vertical header?

philipstarkey commented 5 years ago

Original comment by Russell Anderson (Bitbucket: rpanderson, GitHub: rpanderson).


philipstarkey commented 5 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).


It seems to be setting a custom stylesheet that causes the settings not to be honoured. If I comment out:

self._vertheader.setStyleSheet(headerview_style)

then the problem is no more. However then the font size is bigger and the header takes up an undesirable fraction of total screen space.

I think the font size can be set without stylesheets. I'll have a go at that.

philipstarkey commented 5 years ago

Original comment by Russell Anderson (Bitbucket: rpanderson, GitHub: rpanderson).


On a different host (with the same pyqt version), I don't see this issue. integer_indexing_false_dpi.png integer_indexing_true_dpi.png

philipstarkey commented 5 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).


Resolve issue #46

→ \<\<cset 6c441b863ca65fa3aec7d6cbbdcb822fec136763>>

philipstarkey commented 5 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).


Merged in bugfix2 (pull request #58)

Resolve issue #46

→ \<\<cset 08fdbce223a6806931786de0445a9a202b7c9f82>>

philipstarkey commented 5 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).


Merged in bugfix2 (pull request #58)

Resolve issue #46

→ \<\<cset 08fdbce223a6806931786de0445a9a202b7c9f82>>