search

labscript-suite-temp-2 / lyse

lyse is an analysis framework. It coordinates the running of python analysis scripts on experiment data as it becomes availiable, updating plots in real time.
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Unhandled exception when adding shots without a sequence_index #47

Closed philipstarkey closed 5 years ago

philipstarkey commented 5 years ago

Original report (archived issue) by Russell Anderson (Bitbucket: rpanderson, GitHub: rpanderson).

When using integer_indexing = True in labconfig, we try to catch a missing sequence_index with KeyError or ValueError, but these do not apply, since the value is already set to None in dataframe_utilities.py. The attempt to format the header_strings fails with TypeError.

philipstarkey commented 5 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

Resolves issue #47. We could replace the (KeyError, ValueError) catch with TypeError, but since the existence of the sequence_index column is guaranteed, there's no need. Instead, check for a non-null value using pandas.notna.

→ \<\<cset 23aa15180bb01736b50b22e1246fcba9e520fb95>>