Close button ignored if only clicked once

labscript-suite-temp-2 / lyse

lyse is an analysis framework. It coordinates the running of python analysis scripts on experiment data as it becomes availiable, updating plots in real time.

BSD 2-Clause "Simplified" License

0 stars 0 forks source link

Close button ignored if only clicked once #50

Closed philipstarkey closed 5 years ago

philipstarkey commented 5 years ago

Original report (archived issue) by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

I'm seeing that if lyse is started fresh with no analysis routines loaded, and one clicks close, lyse does not close until the close button is clicked a second time.

This is almost certainly a bug with the change made not long ago that attempts to wait until subprocesses have cleanly exited before closing lyse. Obviously if there are no subprocesses to exit it should close right away but it is not for some reason.

philipstarkey commented 5 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

changed state from "new" to "resolved"

Merged in cbillington/lyse/bugfix (pull request #67)

Fix issue #50: close button unresponsive if there are no routines

→ \<\<cset aaa8485f55d19d868e52015d6420e34344974824>>

philipstarkey commented 5 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

Fix issue #50: close button unresponsive if there are no routines

It seems like QMainWindow.close() cannot be called whilst a close event is currently being handled. Delay call to close() until the mainloop is idle.

→ \<\<cset a98caec8c52d9c8c52aa20c0a5afe56738cc6b58>>

philipstarkey commented 5 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

Merged in cbillington/lyse/bugfix (pull request #67)

Fix issue #50: close button unresponsive if there are no routines

→ \<\<cset aaa8485f55d19d868e52015d6420e34344974824>>