search

labscript-suite-temp-2 / lyse

lyse is an analysis framework. It coordinates the running of python analysis scripts on experiment data as it becomes availiable, updating plots in real time.
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Single shot routines run automatically upon all manually loaded shots #9

Closed philipstarkey closed 9 years ago

philipstarkey commented 9 years ago

Original report (archived issue) by Russell Anderson (Bitbucket: rpanderson, GitHub: rpanderson).

Active single-shot routines run upon manually loading shots into the GUI. Formerly, single-shot routines would only run on new shots sent from BLACS, or those which were "Mark[ed] as not done". This is a problem when loading a lot of shots in, and/or when those shots have already been analysed by the single-shot routine. In the latter case, the routine may have changed (e.g. use different analysis parameters), and the routine will undesirably override previous analysis results.

philipstarkey commented 9 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

Could you test if this was fixed by 4558c2f32abf79fe56dd0c6b67d0ded0e4bf37cf ?

philipstarkey commented 9 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

Actually you don't have to test, I did. Closing, but let me know if for some reason I've overlooked something.

philipstarkey commented 9 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

philipstarkey commented 9 years ago

Original comment by Russell Anderson (Bitbucket: rpanderson, GitHub: rpanderson).

My description wasn't wholly accurate; it's a bit more subtle.

It's actually that new shots (manually loaded or network-submitted) are not marked as done (analysis complete) when being loaded into lyse when there are no active single-shot routines.

Thus the check-box next to the single-shot routines "didn't work", in the sense that if you deactivated all single-shot scripts, then loaded shots in, they wouldn't be marked as done. Then reactivating any single shot routine would result in it running on all the shots you just loaded.

This is exactly what 4558c2f32abf79fe56dd0c6b67d0ded0e4bf37cf fixed.

Note: for those following along at home, lyse does not distinguish manually loaded shots from those submitted over the network at present. This may the subject of a future feature, whereby the user is prompted to mark all manually loaded shots as done upon loading them in.