search

labscript-suite-temp-2 / runmanager

runmanager is a graphical user interface (GUI) used to aid the compilation of labscript experiment scripts into hardware instructions to be executed on the hardware. Experiment parameters can be adjusted in the GUI, and lists of parameters can be used to create sequences of experiments, and scan over complex parameter spaces.
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Cannot select multiple globals with the mouse #14

Closed philipstarkey closed 10 years ago

philipstarkey commented 10 years ago

Original report (archived issue) by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).

It seems that you can't select multiple rows well.

With the mouse, it is impossible.

With the keyboard, you can select multiple rows using the shift key, but cannot use the CTRL key to select non-consecutive rows (well actually you can, if the delete column in the one with focus, and you hit ctrl+space to select the currently focussed row, but dismiss the "do you want to delete this global popup")

This makes the context menu a bit useless!

I'm guessing this used to work, but was broken by changeset: cf4f38006d4011c505ddf76f8f05afd9228338b7

philipstarkey commented 10 years ago

Original comment by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).

philipstarkey commented 10 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

You mean it doesn't work because it goes into editing the globals? It looks to me like it never worked. You can control middle click, though!

Anyway I'll have the mouseclick event check keyboard modifiers and ignore if control is pressed. It would be cleaner if it could be done through QTreeView.setEditFlags, where you just set what things you want to trigger editing, but there is no QTreeView.Clicked flag.

philipstarkey commented 10 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

Fixed in 25c9b57d85d9bc7a3ccbee4bee41aaa6bc562cdf