Missing autoload_config_file raises Exception

labscript-suite-temp-2 / runmanager

runmanager is a graphical user interface (GUI) used to aid the compilation of labscript experiment scripts into hardware instructions to be executed on the hardware. Experiment parameters can be adjusted in the GUI, and lists of parameters can be used to create sequences of experiments, and scan over complex parameter spaces.

BSD 2-Clause "Simplified" License

0 stars 0 forks source link

Missing autoload_config_file raises Exception #17

Closed philipstarkey closed 10 years ago

philipstarkey commented 10 years ago

Original report (archived issue) by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).

If the autoload_config_file parameter in the runmanager section of the LabConfig file points to a file that does not exist, an Exception is raised.

Given that we are printing "loading default config file..." in the output box, we should probably catch/suppress the Exception and print a warning indicating that the file could not be loaded.

philipstarkey commented 10 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

changed state from "new" to "resolved"

Resolves issue #17, failed default loading of config file exception handling.

→ \<\<cset 6033996ae62792e607f093f8c71cefc5186c140c>>

philipstarkey commented 10 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

Huh, really? It doesn't for me, it creates the file, which was what I intended. If you type something in there that isn't even a valid filename, then you get an error, sure. So I've written some code to handle that, but I'm curious, was it not creating the files for you if they were valid filepaths that didn't exist?

philipstarkey commented 10 years ago

Original comment by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).

Ah, I see. The exact scenario was that I specified a blank path :) I assumed it wasn't a special case as it raised the error "WindowsError: [Error 3] The system cannot find the path specified: '' I didn't look closely enough!