labscript-suite-temp-2 / runmanager

runmanager is a graphical user interface (GUI) used to aid the compilation of labscript experiment scripts into hardware instructions to be executed on the hardware. Experiment parameters can be adjusted in the GUI, and lists of parameters can be used to create sequences of experiments, and scan over complex parameter spaces.
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Globals view scrolls horizontally when editing (qt runmanager) #20

Closed philipstarkey closed 10 years ago

philipstarkey commented 10 years ago

Original report (archived issue) by Shaun Johnstone (Bitbucket: shjohnst, GitHub: shjohnst).


The viewport which displays globals and their values seems to scroll to align the "Value" column to the left hand side if the viewport is narrower than the contents (i.e. if there is a horizontal scroll bar).

This is not desired behaviour, since it means that you can no longer see the names of the globals, meaning you don't know which you are editing.

philipstarkey commented 10 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).


Huh. I am unable to reproduce on Ubuntu. Will try on Windows tomorrow, but it's a little odd since Qt has usually very consistent behaviour between Windows and Linux. Any more info on what circumstances this happens in would be appreciated.

philipstarkey commented 10 years ago

Original comment by Shaun Johnstone (Bitbucket: shjohnst, GitHub: shjohnst).


The "value" column was wider than the viewport if that makes a difference. The view scrolled across even when the value which was being edited was short, but other globals in the column had long strings and comments pushing them out to be longer than the view.

I'll investigate later whether there are any other circumstances which make the scrolling come and go.

philipstarkey commented 10 years ago

Original comment by Shaun Johnstone (Bitbucket: shjohnst, GitHub: shjohnst).


OK, I think it's actually the following circumstances:

If the view is too narrow to see the right hand edge of the column which is being edited, the view will shift to try to get the whole column width in the view. This usually means shifting so that the right hand edge of the column is aligned with the right of the view (assuming the view was too far to the left to begin with, this also happens the opposite way for the other side), however if the column is too wide to fit it will align the left hand side with the left side of the view.

GTK runmanager simply didn't scroll to try to help you see what you are doing. While Qt is trying to be helpful, my personal opinion is that it's more useful to be able to see the name of the global you're editing - you can always scroll yourself if you really need to.

philipstarkey commented 10 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).


Yes, I can reproduce now. I'll see what I can do about it.

philipstarkey commented 10 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).


Resolves issue #20: Globals view scrolls horizontally when editing (qt runmanager)

→ \<\<cset 64a6067d83b6b2b55879237b5ef2fdc7dff70dcb>>