Zip groups are overridden when reopening runmanager

labscript-suite-temp-2 / runmanager

runmanager is a graphical user interface (GUI) used to aid the compilation of labscript experiment scripts into hardware instructions to be executed on the hardware. Experiment parameters can be adjusted in the GUI, and lists of parameters can be used to create sequences of experiments, and scan over complex parameter spaces.

BSD 2-Clause "Simplified" License

0 stars 0 forks source link

Zip groups are overridden when reopening runmanager #49

Closed philipstarkey closed 6 years ago

philipstarkey commented 7 years ago

Original report (archived issue) by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).

Zip groups vanish when you reopen runmanager. I don't yet know why, but I can confirm that the globals h5 file does contain the correct informatiojn about zip groups when they are initially set, and that this information is overridden after reopening runmanager.

philipstarkey commented 7 years ago

Original comment by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).

Ok, looks like this only applies to zip groups that were manually defined. Those automatically created by variable dependencies are not affected by this bug (which is probably why we haven't seen it until now)

philipstarkey commented 7 years ago

Original comment by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).

As mentioned in pull request #15, there are still two outstanding bugs that I've uncovered, but have not fixed. These are reported in issue #50

philipstarkey commented 6 years ago

Original comment by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).

changed state from "new" to "resolved"

Fixed several bugs where custom zip groups were overridden. fixes issue #49

→ \<\<cset 00e2f4f88042ceec10dbd154181f25684c010a5e>>