search

labscript-suite-temp-2 / runmanager

runmanager is a graphical user interface (GUI) used to aid the compilation of labscript experiment scripts into hardware instructions to be executed on the hardware. Experiment parameters can be adjusted in the GUI, and lists of parameters can be used to create sequences of experiments, and scan over complex parameter spaces.
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Bugs in Exception handling code under Python 3 #58

Closed philipstarkey closed 6 years ago

philipstarkey commented 6 years ago

Original report (archived issue) by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).

While investigating #56, I noticed that this and this line of code need to be updated as Exception.message doesn't exist under Python 3.

Probably we should look at formatting exceptions properly (with at least a line number from the traceback) rather than just typecasting with str, however that's a bigger job than just those two lines. Whoever decides to pick this up can look into the best approach.

philipstarkey commented 6 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

I hit this too and have made a pull request (pull request #21). Is there any remaining problem if we just make it work on Python 3 as-is? The errors are about global evaluation, so a line number is not relevant to the user - would only be relevant to us in debugging the fact that the exception handling code itself crashed.

philipstarkey commented 6 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

Merged in cbillington/runmanager/bugfix (pull request #21)

FIx issue #58

Approved-by: Philip Starkey philip.starkey@monash.edu

→ \<\<cset 208034a3a463712d79f8f88b41b5c0320f0e2a9b>>

philipstarkey commented 6 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

FIx issue #58

→ \<\<cset 6017b986cfbd4447faba2b647df431f3f9e65c09>>

philipstarkey commented 6 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

Merged in cbillington/runmanager/bugfix (pull request #21)

FIx issue #58

Approved-by: Philip Starkey philip.starkey@monash.edu

→ \<\<cset 208034a3a463712d79f8f88b41b5c0320f0e2a9b>>