Problems with new zprocess changes

labscript-suite-temp-2 / runmanager

runmanager is a graphical user interface (GUI) used to aid the compilation of labscript experiment scripts into hardware instructions to be executed on the hardware. Experiment parameters can be adjusted in the GUI, and lists of parameters can be used to create sequences of experiments, and scan over complex parameter spaces.

BSD 2-Clause "Simplified" License

0 stars 0 forks source link

Problems with new zprocess changes #63

Closed philipstarkey closed 5 years ago

philipstarkey commented 5 years ago

Original report (archived issue) by Lars Kohfahl (Bitbucket: lkohfahl, GitHub: lakodarmstadt).

When encountering another problem with conflicting groups in runmanager (I will write an extra Issue), an error was raised in the function "preparse_globals_loop" as there is still a zprocess.raise_exception_in_thread-function used in it but, if I am correct, zprocess is no longer imported. I also found zprocess being used in "load_configuration" and "compile_loop". Probably this function can just be added to ls_zprocess?

philipstarkey commented 5 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

Thanks for the bug report!

It's fine if runmanager imports zprocess as well for functions that do not need to be wrapped by ls_zprocess, if I removed it it was a mistake. I'll look into it.

philipstarkey commented 5 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

changed state from "new" to "resolved"

Fix regression: restore missing import zprocess.raise_exception_in_thread.

Fixes #63

→ \<\<cset cdfae0e4de170a290380032d2ebbd80f3cdff14c>>