search

labscript-suite-temp-2 / runmanager

runmanager is a graphical user interface (GUI) used to aid the compilation of labscript experiment scripts into hardware instructions to be executed on the hardware. Experiment parameters can be adjusted in the GUI, and lists of parameters can be used to create sequences of experiments, and scan over complex parameter spaces.
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Move delete column of globals treeview to the left #9

Closed philipstarkey closed 10 years ago

philipstarkey commented 10 years ago

Original report (archived issue) by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).

Change in v2.0 that I would like to request is reverted

When the value in the globals column is long (E.g. you have lots of comments in your global value), the delete icon is pushed off to the left of the screen. This makes it annoying because you have to scroll to see the button, but then you can't see the name of teh global you are deleting! The global name and delete buttons should be next to each other.

philipstarkey commented 10 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

Resolved in cf4f38006d4011c505ddf76f8f05afd9228338b7. I only moved it to the right for consistency with the groups tab, because Qt's StandardItemModel doesn't let items other than the first one have children, and it looked silly to have the whitespace between the expander button and the name of a globals file (since there is no delete button in between). I could have had the delete button first in the model but then swapped the columns in the view, but then the highlight looked silly because it had a gap in it, and I wasn't about to go into paint methods over something so trivial!

Anyway it's probably fine as it is now even though there's inconsistency between the group and globals tabs.