labscript-suite-temp-2 / runviewer

BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Smaller plots for digitals #14

Open philipstarkey opened 7 years ago

philipstarkey commented 7 years ago

Original report (archived issue) by Jan Werkmann (Bitbucket: PhyNerd, GitHub: PhyNerd).


I propose having digital outputs such as shutters, digitalouts and clocklines display in a smaller plot (smaller y axis) as they don't profit from the extra space. They should also get their y-axis-ticks replaced with Hi and Lo to distinguish them from analog outputs. Here is a screenshot I made of how things could look (ignoring the markers, non linear time and different label position): Bildschirmfoto 2017-06-27 um 22.18.16.png

philipstarkey commented 7 years ago

Original comment by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).


Yeah, this makes sense. We should probably have a preferences pane so you can configure the height of them or something like that.

philipstarkey commented 6 years ago

Original comment by Shaun Johnstone (Bitbucket: shjohnst, GitHub: shjohnst).


Preferences for settings on a per output type basis would be good. Could we make it that the height of each plot can be adjusted manually by dragging a bar between them too? E.g. if you have a channel with lots of variation you can then make it bigger than other channels that don't change much.

philipstarkey commented 6 years ago

Original comment by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).


I had been wondering recently if we should just put the plots inside a QSplitter. We could save the splitter positions as part of the channel config.

philipstarkey commented 6 years ago

Original comment by Jan Werkmann (Bitbucket: PhyNerd, GitHub: PhyNerd).


I've tried to create a pull request with our labs code for the smaller plots, but quickly realized that this is not really possible with the axis names on the left axis (they are quickly cut off). Because we use non linear time in most cases we disable the time axis for all plots in our lab. This allows to placed the channel name in the plot titles without losing space. This will also allow to make plots arbitrarily small. Here is a screenshot: screenshot.png Before I create a pull request with these changes are there better ideas to maximize the amount of visible plots?