Closed philipstarkey closed 7 years ago
Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).
Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).
Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).
Original comment by Jan Werkmann (Bitbucket: PhyNerd, GitHub: PhyNerd).
I think we should merge the pull requests now they should be quite well tested by now and except for the lyse pull request #31 they don't seem critical.
Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).
Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).
All merged and all repos tagged with a minor version bump.
This might not be ideal since some recently merged features might have benefited from more testing, but at least this way the installer no longer results in a known-to-be-broken set of versions.
Todo still is to write some release notes.
Original comment by Jan Werkmann (Bitbucket: PhyNerd, GitHub: PhyNerd).
Most of the recently merged changes are running in our lab for quite a while now. I'd say they are well tested.
Not sure what you put in your release notesbut here is a list of all the changes that happen since the last version bumps:
Runviewer:
Runmanager:
labscript_utils:
labscript_devices:
labscript:
BLACS:
lyse:
Original report (archived issue) by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).
This is a list of pull requests it would be nice to merge in the next week or so so that we can stamp all of the repos with version numbers as a release. Presently the installer results in a set of versions that are not compatible with each other, which was a mistake, so we should stamp new versions everywhere soon so that a fresh install is back to something sensible. And then we can send an email to the mailing list as a release announcement.
These are bugfixes, mostly relevant to recent changes, and the dragdroptabs and change to the installer to allow for things to work (as far as we know so far) for PyQt5, though our release announcement should say that PyQt5 support is 'experimental'. Plus the pulseblaster workaround that is in use in a lab at NIST.
Installer pull request #4, allow PyQt5.labscipt_utils pull request #21, dragdroptab*~~ lyse pull request #31, Fix a bug in updating the dataframe~~
lyse pull request #32, Only restore window geometry if screen geometry is the samelyse pull request #33, Fixes issue #27 (labscript-suite-temp/lyse#27): lyse broken after analysis loop crashlabscript_devices pull request #17, time based shot duration workaround for old pulseblastersif @pstarkey @shjohnst @PhyNerd or anyone else who is interested could deploy some or all of the pull requests to actual labs (I know some already are) and comment that they've done so, then that would be really great, and if we haven't seen any issues after a week or so then we can merge them all and declare success.
Other development of new features and python 3 compatibility can then continue.