Timeout trigger of wait monitor doesn't change state

labscript-suite-temp / labscript_devices

Module containing labscript suite hardware compatibility, separate from the main programs. Device compatibility is implemented with a plugin architecture, for modularity and extensibility. Each file in this module contains a labscript device class, a BLACS tab class, a BLACS worker class and a runviewer parser class for a particular device. These implement functionality for the device which the programs in question call on when they encounter each device in user labscript code, hdf5 files, or connection tables.

0 stars 0 forks source link

Timeout trigger of wait monitor doesn't change state #17

Closed philipstarkey closed 6 years ago

philipstarkey commented 7 years ago

Original report (archived issue) by Russell Anderson (Bitbucket: rpanderson, GitHub: rpanderson).

The send_resume_trigger function of the NI_PCIe_6363 issues two identical instructions to the timeout_connection, i.e. failing to produce a rising/falling edge.

philipstarkey commented 7 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

Well, that's a bit of an oversight. Will fix.

philipstarkey commented 7 years ago

Original comment by Russell Anderson (Bitbucket: rpanderson, GitHub: rpanderson).

I've fixed this in the monashspinor fork (commit).

philipstarkey commented 6 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

changed state from "new" to "resolved"

This appears to have been fixed by the introduction of configurable edge direction for wait timeout triggers.