search

labscript-suite-temp / lyse

lyse is an analysis framework. It coordinates the running of python analysis scripts on experiment data as it becomes availiable, updating plots in real time.
BSD 2-Clause "Simplified" License
0 stars 0 forks source link

Multi-shot analysis routines still run when analysis is paused #14

Open philipstarkey opened 9 years ago

philipstarkey commented 9 years ago

Original report (archived issue) by Shaun Johnstone (Bitbucket: shjohnst, GitHub: shjohnst).

If a multishot analysis routine returns an error (e.g. due to a failed fit) it pauses the analysis queue. However, as new shots come in, the single shot routines do not run, as expected, but multishot routines continue. In the case where the mutishot requires results from the single shot the error is unlikely to go away. In the case where the multishot does not rely on results from a single shot routine, the error may go away (e.g. once enough shots are in to allow it to fit) meaning that there are now no scripts in an error state, but analysis is paused.

To be consistent, multishot should pause when single shot is paused.

philipstarkey commented 7 years ago

Original comment by Jan Werkmann (Bitbucket: PhyNerd, GitHub: PhyNerd).

should be fixed if you replace the last break in analysis_loop() with a return

#!python

                else:
                    logger.info('analysis is paused')
                    break
            if self.multishot_required and not self.analysis_paused:
                logger.info('doing multishot analysis')
                self.do_multishot_analysis()