search

labscript-suite / blacs

𝗯𝗹𝗮𝗰𝘀 supervises the execution of experiments controlled by the 𝘭𝘢𝘣𝘴𝘤𝘳𝘪𝘱𝘵 𝘴𝘶𝘪𝘵𝘦. It manages experiment queuing and hardware-timed execution, and provides manual control over devices between shots.
http://labscriptsuite.org
Other
4 stars 48 forks source link

Exclude queue_data from Frontpanel settings stored to shots #39

Closed philipstarkey closed 6 years ago

philipstarkey commented 6 years ago

Original report (archived issue) by Jan Werkmann (Bitbucket: PhyNerd, GitHub: PhyNerd).

We had a very long measurement today with about 40 000 shots. And noticed that shot files that had run were very large(400mb). After looking at them we noticed, that all of them had a very long list of shots, that were in the queue when they were executed, stored in the h5 file. Removing this list reduced files to a more sensible size.

I propose we exclude queue_data from being stored in shot files after they have run. Before I create a pull request: Is there any reason to include the queue_data in the stored front panel settings?

philipstarkey commented 6 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

I don't think there is a reason, other than code re-use: the same code that saves front panel state in general saves it to all shot files. But when restoring front panel state from an already-run shot file, I don't think anyone would be upset if the queue contents were not restored. So adding a keyword argument to whichever function call saves the data to tell it to exclude this, and having the calling code use that keyword arg when it saves data to run shot files seems fine to me.

philipstarkey commented 6 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

Resolved by pull request #40