Implement abort during delay when using cycle_time plugin

labscript-suite / blacs

𝗯𝗹𝗮𝗰𝘀 supervises the execution of experiments controlled by the 𝘭𝘢𝘣𝘴𝘤𝘳𝘪𝘱𝘵 𝘴𝘶𝘪𝘵𝘦. It manages experiment queuing and hardware-timed execution, and provides manual control over devices between shots.

http://labscriptsuite.org

Other

4 stars 48 forks source link

Implement abort during delay when using cycle_time plugin #55

Open philipstarkey opened 4 years ago

philipstarkey commented 4 years ago

Original report (archived issue) by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

In PR #50, the "cycle_time" plugin, I did not implement handing the case where the user clicks the abort button whilst the experiment queue is waiting for the target time before running the next shot. Nothing is checking for the abort event whilst the queue is waiting, and this means the abort does not actually occur until after transition_to_buffered, which isn't what you want.

zakv commented 3 years ago

I believe this issue is actually resolved. The cycle_time plugin connects to the abort button here:

https://github.com/labscript-suite/blacs/blob/2bd2aa6c9dc20fa9674676619aec4d9d4d53848b/blacs/plugins/cycle_time/__init__.py#L97

I briefly tried it out as well and was able to abort shots during the added delay period.