labscript-suite / labscript-devices

A modular and extensible plugin architecture to control experiment hardware using the 𝘭𝘒𝘣𝘴𝘀𝘳π˜ͺ𝘱𝘡 𝘴𝘢π˜ͺ𝘡𝘦.
http://labscriptsuite.org
Other
5 stars 58 forks source link

PrawnBlaster runviewer parser drops first instruction after a wait with timeout #109

Open dihm opened 8 months ago

dihm commented 8 months ago

Issue is in this if-elif-else block

https://github.com/labscript-suite/labscript-devices/blob/e1f3d322662876564524e44938424572790f1232/labscript_devices/PrawnBlaster/runviewer_parsers.py#L96-L115

The elif block always triggers on the next instruction after a wait, even if the current instruction is not also a wait (the proper indication of an indefinite wait).

Pretty sure the elif check should be elif row["reps"] == 0 and last_instruction_was_wait: