labscript-suite / labscript-devices

A modular and extensible plugin architecture to control experiment hardware using the 𝘭𝘒𝘣𝘴𝘀𝘳π˜ͺ𝘱𝘡 𝘴𝘢π˜ͺ𝘡𝘦.
http://labscriptsuite.org
Other
5 stars 58 forks source link

TekScope bug fix #118

Closed ispielma closed 2 months ago

ispielma commented 2 months ago

The TekScope device had a bug where it was calling hdf_file.create_group('/data/traces') in transition to manual. This is a problem because if you have two scopes this code fails the second time. Instead (and like the camera devices) I changed this to grp = hdf_file.require_group('/data/traces'). Trivial.

Also in transition to buffered the code self.scope.dev.timeout = 1000 * self.scope_params.get('timeout', 5) appeared while the h5 file was open (which was not needed). Moved this after closing the h5 file to slightly reduce the time that the file was locked.