extract_measurements of NI cards incompatible with numpy >= 1.12

labscript-suite / labscript-devices

A modular and extensible plugin architecture to control experiment hardware using the 𝘭𝘢𝘣𝘴𝘤𝘳𝘪𝘱𝘵 𝘴𝘶𝘪𝘵𝘦.

http://labscriptsuite.org

Other

5 stars 58 forks source link

extract_measurements of NI cards incompatible with numpy >= 1.12 #25

Closed philipstarkey closed 6 years ago

philipstarkey commented 6 years ago

Original report (archived issue) by Russell Anderson (Bitbucket: rpanderson, GitHub: rpanderson).

As of numpy 1.12, indexing with floats raises IndexError. This occurs in extract_measurements, as numpy.floor and numpy.ceil (used to define start_index and stop_index) return floats.

philipstarkey commented 6 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

changed state from "new" to "resolved"

Resolves issue #25, where IndexError was raised in extract_measurements of NI devices since numpy 1.12.

→ \<\<cset d7aabfab49127249688e490936b63d398d69cf69>>