search

labscript-suite / labscript-devices

A modular and extensible plugin architecture to control experiment hardware using the 𝘭𝘒𝘣𝘴𝘀𝘳π˜ͺ𝘱𝘡 𝘴𝘢π˜ͺ𝘡𝘦.
http://labscriptsuite.org
Other
5 stars 58 forks source link

SpinnakerCamera #42

Closed dsbarker closed 4 years ago

dsbarker commented 4 years ago

This pull request contains a new camera interface that uses FLIR's PySpin/Spinnaker API. SpinnakerCamera is intended for users of FlyCapture2Camera that want to run labscript with Python 3.6 and newer. SpinnakerCamera requires PySpin and the Spinnaker SDK. The new code was written by S. Eckel.

We've successfully tested SpinnakerCamera in our lab using Flea3 13Y3M. During testing/coding, we've noticed that PySpin has some bugs related to when/if certain camera parameters can be set (this problem also occurs in FlyCapture2). Presumably, the parameter programming order does not depend on camera model, but we cannot be sure. Other users should be aware of the general shoddiness of FLIR's python code when deploying on their apparatus.

DSB

philipstarkey commented 4 years ago

@chrisjbillington These all look easy to solve ourselves - are you happy if I push minor changes so we can merge before the 3.0.0 release?

chrisjbillington commented 4 years ago

@philipstarkey yep, that sounds fine to me!

dsbarker commented 4 years ago

Thank you for taking care of the changes. They’re continually being pushed to the bottom of my to-do list.

On Jun 22, 2020, at 10:16 PM, Chris Billington notifications@github.com wrote:

ο»Ώ @philipstarkey yep, that sounds fine to me!

β€” You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.

philipstarkey commented 4 years ago

@dsbarker Do I have permission to push to your branch? There should be a checkbox on the right hand side of this page to allow project authors to push changes to this PR. If it is already checked I might be doing something wrong on my end...

rpanderson commented 4 years ago

If it is already checked I might be doing something wrong on my end...

It's not already checked @philipstarkey , otherwise you and I would see a "Add more commits by pushing to the SpinnakerCamera branch on JQIamo/labscript-devices" immediately below the most recent message (which I don't).

dsbarker commented 4 years ago

Hmmm... The checkbox is not there. The problem is likely that the fork is in the JQIamo. Perhaps even with organization ownership privileges, I'm not allowed to give you permission in this way? I'll give you access to the fork manually and that should fix it.

dsbarker commented 4 years ago

I've just sent an invite to my fork.