search

labscript-suite / labscript-devices

A modular and extensible plugin architecture to control experiment hardware using the 𝘭𝘒𝘣𝘴𝘀𝘳π˜ͺ𝘱𝘡 𝘴𝘢π˜ͺ𝘡𝘦.
http://labscriptsuite.org
Other
5 stars 58 forks source link

Break circular dependencies in the labscript-suite #59

Closed philipstarkey closed 2 years ago

philipstarkey commented 4 years ago

We currently have circular dependencies where labscript-devices depends on BLACS, and vice versa.

I think we can break this by migrating the contents of __init__.py over to labscript-utils. If this was then imported into labscript-devices it would also remain backwards compatible. BLACS (and runviewer) would then access the labscript-devices import machinery via labscript-utils, breaking the circular dependency.

philipstarkey commented 4 years ago

This would also mean that installing runviewer didn't require installing blacs (runviewer depends on labscript-devices which depends on blacs)

dihm commented 2 years ago

Everything is finally merged, so going to close this.