Open chrisjbillington opened 3 years ago
This looks great! I tested it with our PCO camera which inherits from the IMAQdxCamera classes and it worked well. I just have a few questions/comments
image_receiver.image
gets set to None
and then image_receiver.update_image()
gets called, which throws AttributeError: 'NoneType' object has no attribute 'swapaxes'
.
image_receiver.set_bg_image()
only set the background image and call self.update_image()
if self.image is not None
.image_receiver.set_bg_image()
should probably also return True
or False
indicating whether or not it updated the background image. Then IMAQdxCameraTab.on_set_bg_clicked()
should only show/hide buttons if the background image was actually set.IMAQdxCameraTab.get_save_data()
and IMAQdxCameraTab.get_save_data()
, but git handled the merge just fine without any manual intervention.ImageView
(see screenshot below), but I think I was wrong.
normalize()
method in particular) it looks like it's designed for image arrays that are 3D (e.g. a series of images displayed together) so it doesn't do exactly what is done by the code in this PR.
Add optional autoscaling to IMAQdxCamera. Previously, autoscaling was always on.
Add basic background subtraction. A background can be set, which will be subtracted from subsequent images in manual mode.