search

labscript-suite / labscript-devices

A modular and extensible plugin architecture to control experiment hardware using the 𝘭𝘒𝘣𝘴𝘀𝘳π˜ͺ𝘱𝘡 𝘴𝘢π˜ͺ𝘡𝘦.
http://labscriptsuite.org
Other
5 stars 58 forks source link

Fix recent AI termination changes to work with DAQs that don't have analog inputs #90

Closed dihm closed 2 years ago

dihm commented 2 years ago

Just tried the changes in #75 on a DAQ without analog inputs and found a fairly important edge case in the logic. Basically, the changes I made assume analog inputs exist.

This PR adds a bit of logic to handle the case when the DAQ has no analog inputs.

dihm commented 2 years ago

Ugh. Docs builds just crashed because of a package update on mistune that breaks m2r, which is no longer maintained. Going to have to either pin mistune==0.8.2 or switch to m2r2, the updated version of m2r started by someone else. For every repository...