search

labscript-suite / labscript-utils

Shared modules used by the 𝘭𝘒𝘣𝘴𝘀𝘳π˜ͺ𝘱𝘡 𝘴𝘢π˜ͺ𝘡𝘦. Includes a graphical exception handler, debug tools, configuration management, cross platform filepath conversions, unit conversions and custom GUI widgets.
http://labscriptsuite.org
Other
2 stars 45 forks source link

Imp hotfix #105

Closed dihm closed 2 months ago

dihm commented 5 months ago

This helps with the new issue introduced by #101 where python versions <3.12 don't work in resolving the device registry.

It partially addressed #100 more fully by removing the use of imp entirely in the device registry code. New method now directly runs the register_classes.py modules, but does not fully import them (ie doesn't add to sys.modules). This is the intended behavior of the device registry and should help simplify the code a bit. Some testing will be needed to ensure tab reloads and runmanager reloads still function as intended.

dihm commented 5 months ago

@ispielma If you could test this PR out, it would be greatly appreciated!