labscript-suite / labscript

The 𝗹𝗮𝗯𝘀𝗰𝗿𝗶𝗽𝘁 library provides a translation from expressive Python code to low-level hardware instructions.
http://labscriptsuite.org
BSD 2-Clause "Simplified" License
9 stars 52 forks source link

Update `Trigger` to support the `inverted` kwarg #109

Open philipstarkey opened 9 months ago

philipstarkey commented 9 months ago

It looks like Trigger was written without considering the DigitalOut inverted kwarg. This potentially leads to some confusing behaviour, see #93.

We should look at fixing this so it is consistent. However, case needs to be taken to ensure it is backwards compatible, particularly with PulseBlaster's as secondary pseudoclocks (as PulseBlasters have inverted digital triggers and Trigger was likely written specifically for that use case).