search

labscript-suite / labscript

The 𝗹𝗮𝗯𝘀𝗰𝗿𝗶𝗽𝘁 library provides a translation from expressive Python code to low-level hardware instructions.
http://labscriptsuite.org
BSD 2-Clause "Simplified" License
9 stars 51 forks source link

StaticDDS class does not ask parent device for default unit conversion classes like DDS class #33

Closed philipstarkey closed 4 years ago

philipstarkey commented 7 years ago

Original report (archived issue) by David Meyer (Bitbucket: dihm, GitHub: dihm).

It's a minor annoyance, but getting the right number of zeros on a Novatech to set 80MHz in Hz is tedious.

There is a simple copy/paste upgrade from the DDS class. I can send a pull request with the fix I've been using for a while now.

philipstarkey commented 7 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

I have fixed this in the Spielman labs as well, but there are some other changes there too that I need to look at before merging the lot in which is why it hasn't been merged yet. Getting the Spielman and mainline forks back together is a priority at the moment so this will happen soon.

I'd say keep using your own fix for now and I'll get our fix into the mainline soon! The fixes ought to be compatible - as you've seen it's not that complicated a problem to fix. I'll leave this bug report open until the fix is in mainline.

philipstarkey commented 4 years ago

This was fixed in 5b2826c48ad19d3e54fc3b2c73bcaf76e15b6532