labscript-suite / labscript

The 𝗹𝗮𝗯𝘀𝗰𝗿𝗶𝗽𝘁 library provides a translation from expressive Python code to low-level hardware instructions.
http://labscriptsuite.org
BSD 2-Clause "Simplified" License
9 stars 48 forks source link

instruction times should be quantised to the pseudoclock clock_resolution #40

Closed philipstarkey closed 7 years ago

philipstarkey commented 7 years ago

Original report (archived issue) by Shaun Johnstone (Bitbucket: shjohnst, GitHub: shjohnst).


As per pull request #11, there is a bug where the 'extra clock tick' that can be inserted just before a break in a ramp* may be shortened incorrectly (and thus tick faster than the allowed clock_limit rate of an attached ClockLine) due to the quantisation of the pseudoclock.

EDIT: This was reported by @philipstarkey (@shjohnst was just logged into the PC)


* The break in ramps is a result of labscript automatically splitting ramps when another output needs to be updated during the middle of a ramp

philipstarkey commented 7 years ago

Original comment by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).


philipstarkey commented 7 years ago

Original comment by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).


philipstarkey commented 7 years ago

Original comment by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).


fixes issue #40

→ \<\<cset 32213b7c667309f54327390561284bf7202e3b8e>>