labscript-suite / labscript

The 𝗹𝗮𝗯𝘀𝗰𝗿𝗶𝗽𝘁 library provides a translation from expressive Python code to low-level hardware instructions.
http://labscriptsuite.org
BSD 2-Clause "Simplified" License
9 stars 48 forks source link

pseudoclock wait_delay is probably not respected #50

Open philipstarkey opened 5 years ago

philipstarkey commented 5 years ago

Original report (archived issue) by Philip Starkey (Bitbucket: pstarkey, GitHub: philipstarkey).


As per the comment chain in this pull request over on the labscript_devices repository, I suspect that the wait_delay attribute of secondary pseudoclocks is not being respected, and thus the master pseudoclock may not wait a sufficient time before emitting a trigger pulse to resume the shot.

This would result in secondary pseudoclocks becoming out of sync with the primary, which may explain the occasional dropped shots seen in the monash spinor BEC lab.

We should check to see if it is easy to fix in labscript 2, or if we need to wait until labscript 3 in order to correctly offset instruction times for secondary pseudoclocks.