labscript-suite / labscript

The 𝗹𝗮𝗯𝘀𝗰𝗿𝗶𝗽𝘁 library provides a translation from expressive Python code to low-level hardware instructions.
http://labscriptsuite.org
BSD 2-Clause "Simplified" License
9 stars 52 forks source link

Change default of save_hg_info to #90

Closed ispielma closed 2 years ago

ispielma commented 2 years ago

There is no reason that we should be default trying to save hg info (particularly since we have moved to github). In my case, this cased a problem in runmanager whereby the compile thread would hard-crash when the vcs function could not find the hg executable. Of course one solution here is to use the save_hg_info (or save_git_info) option in the labconfig file, but since these do not appear in the default files I think it is better to turn off the option be default.

chrisjbillington commented 2 years ago

Yep, this is a no-brainer.