search

labscript-suite / runmanager

𝗿𝘂𝗻𝗺𝗮𝗻𝗮𝗴𝗲𝗿 is an intuitive graphical interface for controlling 𝘭𝘢𝘣𝘴𝘤𝘳𝘪𝘱𝘵 𝘴𝘶𝘪𝘵𝘦 experiments. Includes multi-dimensional parameter scans and a remote programming interface for automation.
http://labscriptsuite.org
Other
3 stars 45 forks source link

Check if global group names are valid hdf5 group names #102

Closed zakv closed 2 years ago

zakv commented 3 years ago

Fixes #101 by implementing the changes suggested there. Runmanager now ensures that names for globals groups only contain ASCII characters and do not contain "/" or ".".

If the user attempts to create a group with an invalid name, then an error message will pop up informing the user that the provided name is invalid and no new group will be created. Similarly if the user attempts to rename an existing group to an invalid name, then an error message will pop up informing the user that the provided name is invalid and the group will keep its previous name.

dihm commented 2 years ago

This looks ready to merge to me, if you still agree @zakv.

Note: somewhat annoying, I notice that Python 3.7 includes a built-in function to check if a string is only ASCII characters. Too bad we still support 3.6.

zakv commented 2 years ago

Yep! I'll go ahead and merge it then