search

labscript-suite / runmanager

𝗿𝘂𝗻𝗺𝗮𝗻𝗮𝗴𝗲𝗿 is an intuitive graphical interface for controlling 𝘭𝘢𝘣𝘴𝘤𝘳𝘪𝘱𝘵 𝘴𝘶𝘪𝘵𝘦 experiments. Includes multi-dimensional parameter scans and a remote programming interface for automation.
http://labscriptsuite.org
Other
3 stars 45 forks source link

Update "Save file"-text after using "save as" #103

Closed lakodarmstadt closed 3 years ago

lakodarmstadt commented 3 years ago

When using "save as" the save_file path is updated such that when using save or STRG+S the file is saved to the path last set by "save as" but this path is not shown in the drop-down menu. Basically this is just the last commit. Sry for the "waste-commits" before.

zakv commented 3 years ago

Just tested this and it looks good. I was able to reproduce the bug without this PR, then saw that the PR does resolve the issue.

My only suggestion would be to use an f-string or use the .format() method of strings as those approaches are generally preferred over the old %-style string formatting. This is a simple enough case though where using the %-style is still easily readable.

lakodarmstadt commented 3 years ago

Thanks Zak for testing. I have changed string formatting to use .format().

zakv commented 3 years ago

Looks great! I'll merge this once I get familiar with labscript's merging procedures

lakodarmstadt commented 3 years ago

Thanks