search

labscript-suite / runmanager

𝗿𝘂𝗻𝗺𝗮𝗻𝗮𝗴𝗲𝗿 is an intuitive graphical interface for controlling 𝘭𝘢𝘣𝘴𝘤𝘳𝘪𝘱𝘵 𝘴𝘶𝘪𝘵𝘦 experiments. Includes multi-dimensional parameter scans and a remote programming interface for automation.
http://labscriptsuite.org
Other
3 stars 45 forks source link

Globals diffing broken in pandas 0.20.1 #40

Closed philipstarkey closed 7 years ago

philipstarkey commented 7 years ago

Original report (archived issue) by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

Globals diffing is broken with pandas 0.20.1

#!python

Traceback (most recent call last):
  File "/home/cjb7/labscript_suite/runmanager/__main__.py", line 1942, in on_diff_globals_file_clicked
    globals_diff_table = runmanager.globals_diff_groups(active_groups, other_groups)
  File "/home/cjb7/labscript_suite/runmanager/__init__.py", line 805, in globals_diff_groups
    df = df.sort()
  File "/usr/local/lib/python2.7/dist-packages/pandas/core/generic.py", line 2970, in __getattr__
    return object.__getattribute__(self, name)
AttributeError: 'DataFrame' object has no attribute 'sort'
philipstarkey commented 7 years ago

Original comment by Chris Billington (Bitbucket: cbillington, GitHub: chrisjbillington).

Fixed by b0794cc31b5dfc92df1ee60efccbf334948a01bf (pull request #6)