search

labscript-suite / runviewer

π—Ώπ˜‚π—»π˜ƒπ—Άπ—²π˜„π—²π—Ώ is a graphical interface for visualising hardware-timed experiments composed using the 𝘭𝘒𝘣𝘴𝘀𝘳π˜ͺ𝘱𝘡 𝘴𝘢π˜ͺ𝘡𝘦.
http://labscriptsuite.org
BSD 2-Clause "Simplified" License
2 stars 39 forks source link

Obtain own version without external functions #36

Closed rpanderson closed 4 years ago

rpanderson commented 4 years ago

Per labscript-suite/runmanager#81, with the addition of making the importlib_metadata requirement python<'3.8'.

chrisjbillington commented 4 years ago

Leaving the importlib_metadata requirement version-independent was actually intentional for runmanager.

For packages where having an extra dependency is harmless, this allows us to build python-version-independent conda packages.

However since runviewer has a C extension, a python- and os-agnostic package is not possible in any-case, so it doesn't matter here!

chrisjbillington commented 4 years ago

By the way, in case you didn't see this in the runmanager commit messages, the reasoning behind manually checking for a .git directory (even though setuptools_scm does this itself) is that setuptools_scm is a very heavy import due to importing pkg_resources, so we want to avoid it unless we know we're going to use it!