search

labscript-suite / runviewer

π—Ώπ˜‚π—»π˜ƒπ—Άπ—²π˜„π—²π—Ώ is a graphical interface for visualising hardware-timed experiments composed using the 𝘭𝘒𝘣𝘴𝘀𝘳π˜ͺ𝘱𝘡 𝘴𝘢π˜ͺ𝘡𝘦.
http://labscriptsuite.org
BSD 2-Clause "Simplified" License
2 stars 39 forks source link

Remove shot from "select markers" drop down when shot is removed #61

Closed carterturn closed 8 months ago

carterturn commented 9 months ago

The pull request attempts to resolve issue #44 by removing shots from the "select markers" drop down when the shot is removed from runviewer. It successfully avoids issues with shots being loaded, deleted, and loaded again. However, this PR does change the behavior of runviewer in that previously loaded shots are no longer visible (greyed out) in the "select markers" drop down. In my opinion, the new behavior is acceptable, and---since the entries for deleted shots are greyed out---it should not impact workflows. The case of loading the same shot twice, the removing one or both also seems to be handled correctly.

dihm commented 8 months ago

Confirmed this fixes the issue. Agreed that there is no worry about changing workflow or anything. Merging.

dihm commented 8 months ago

Thanks for the Fix!