labsquare / FastQt

FastQC port to Qt5: A quality control tool for high throughput sequence data.
GNU General Public License v3.0
110 stars 25 forks source link

Support of uBAM file #61

Closed ikit closed 7 years ago

ikit commented 7 years ago

:+1:

natir commented 7 years ago

@ikit Where I can find the uBAM specification format ?

natir commented 7 years ago

Wheel,

We can use bamtools to read sam, bam and unaligned bam file.

But add this dependency maybe become hard (multi-plateform trouble), I work on this.

natir commented 7 years ago

Ok with htslib we can read uBAM file actualy we can detect the BAM file format and open the file. But when I try run analysis, FastQt generate a segfault, I don't know if is my file or is the code. @dridk you know where I can get a standard bamfile ?

dridk commented 7 years ago

You can find fastq, bam and vcf file here : http://www.internationalgenome.org/data-portal/sample Why not using htslib to read bam ? You can check the code from https://github.com/labsquare/CuteVCF

natir commented 7 years ago

@dridk we use htslib to read bam

dridk commented 7 years ago

Sorry, I was reading the old mesage with bamtools

natir commented 7 years ago

Well,

I think the support of ubam file is ready, I use the quality mapping field for sequence quality.

For test, I convert a fastqt file with this gatk tutoriel, the result is similar when we use fastqt or ubam.

I want reread code for remove deadcode, no C++ code, and search some bug, but this issue is close to be closed :)

natir commented 7 years ago

Ok htslib branch is ready to merge, maybe we need check this branch run on windows before, merging in devel.

We can't have a progression bar for ubam/bam file.

natir commented 7 years ago

@dridk @ikit or other people can check if htslib branch is fully functional and code isn't too ugly.

dridk commented 7 years ago

I get unexpected crash with all bam tested :

image

dridk commented 7 years ago

Don't understand... aln->core.l_qseq return always 0. I tested other parameter like chromosom and position. They works