search

labstack / echo-contrib

Echo community contribution
https://echo.labstack.com
MIT License
175 stars 92 forks source link

NewTracedRequest - nil Body #44

Closed Dredouane closed 1 year ago

Dredouane commented 3 years ago

https://github.com/labstack/echo-contrib/blob/fd0452527ce01ce8a4801451d351aa093f169b97/jaegertracing/jaegertracing.go#L240

POST requests are sent with a nil body? the body param is not used or I'm missing something? Thanks

arun0009 commented 3 years ago

@carlosedp I think this is a bug? @Dredouane feel free to pass the body to the line you referenced and open a PR maybe?

m1x0n commented 2 years ago

This bit should fix https://github.com/labstack/echo-contrib/pull/71

m1x0n commented 1 year ago

Fixed in https://github.com/labstack/echo-contrib/releases/tag/v0.13.1