labstack / echo-contrib

Echo community contribution
https://echo.labstack.com
MIT License
175 stars 92 forks source link

casbin: add EnforceHandler to allow custom callback to handle enforcing. #66

Closed aldas closed 2 years ago

aldas commented 2 years ago

casbin:

CI:

This should be enought to handle cases for: #58, #61 and #65

codecov[bot] commented 2 years ago

Codecov Report

Merging #66 (d222dcd) into master (4d116ee) will increase coverage by 1.35%. The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   55.41%   56.76%   +1.35%     
==========================================
  Files           8        8              
  Lines         462      643     +181     
==========================================
+ Hits          256      365     +109     
- Misses        186      256      +70     
- Partials       20       22       +2     
Impacted Files Coverage Δ
casbin/casbin.go 89.13% <92.85%> (+4.51%) :arrow_up:
zipkintracing/tracing.go 63.73% <0.00%> (-5.02%) :arrow_down:
session/session.go 88.46% <0.00%> (-1.02%) :arrow_down:
pprof/pprof.go 100.00% <0.00%> (ø)
jaegertracing/body_dump_response_writer.go 50.00% <0.00%> (ø)
jaegertracing/jaegertracing.go 48.79% <0.00%> (+2.02%) :arrow_up:
prometheus/prometheus.go 51.94% <0.00%> (+2.50%) :arrow_up:
zipkintracing/response_writer.go 21.27% <0.00%> (+5.27%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4d116ee...d222dcd. Read the comment docs.

aldas commented 2 years ago

@lammel could you review

aldas commented 2 years ago

@lammel ping

mcauto commented 2 years ago

LGTM :) Why not release it yet?

aldas commented 2 years ago

Should be ok now. Tagged a new release - 0.12.0.