labstack / echo

High performance, minimalist Go web framework
https://echo.labstack.com
MIT License
29.01k stars 2.21k forks source link

Change type definition blocks to single declarations. This helps copy… #2606

Closed aldas closed 4 months ago

aldas commented 4 months ago

Change type definition blocks to single declarations. This helps copy/pasting Echo code in examples (for issues and discussions and for Echo website).

I admit this is yak shaving but answering issues with good examples is probably biggest time sink when it comes to maintaining Echo. And I feel that is important to answer with examples etc. Also - website middleware part has block with middleware configurations. It is dedious to copy/paste middleware conf type there and have markdown intentation broken (blocks like that https://github.com/labstack/echox/blob/master/website/docs/middleware/csrf.md#configuration).

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.19%. Comparing base (5f7bedf) to head (0176cd9).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2606 +/- ## ========================================== - Coverage 93.19% 93.19% -0.01% ========================================== Files 41 41 Lines 4690 4689 -1 ========================================== - Hits 4371 4370 -1 Misses 230 230 Partials 89 89 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

aldas commented 4 months ago

@vishr I need your blessing :) I hope this is OK.

vishr commented 4 months ago

@vishr I need your blessing :) I hope this is OK.

Totally.