labstack / echo

High performance, minimalist Go web framework
https://echo.labstack.com
MIT License
29.01k stars 2.21k forks source link

Remove maxparam dependence from Context #2611

Closed aldas closed 3 months ago

aldas commented 3 months ago

This addresses race when Context is changing echo.Echo.maxParam value. This change does not address issues with Router not being safe when routes are added when server has already started and is serving incoming requests. This case is still unsafe (multiple goroutines writing+reading route tree)

Relates to https://github.com/labstack/echo/issues/1705

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.02%. Comparing base (011acb4) to head (45dc264).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2611 +/- ## ========================================== - Coverage 93.03% 93.02% -0.01% ========================================== Files 41 41 Lines 4706 4703 -3 ========================================== - Hits 4378 4375 -3 Misses 236 236 Partials 92 92 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.