Closed aldas closed 3 years ago
@lammel could you review when you have the time
We should merge to make it available as github page to point the current docs page also to the new github pages based docs then.
I have not tested that part myself but when different domain is used the publish workflow needs to be changed as hugo needs be told of actual base url hugo -D --baseURL $BASE_URL
. This is needed as some of the links in docs are not relative and depend on base url.
Github docs about custom domain: https://docs.github.com/en/github/working-with-github-pages/managing-a-custom-domain-for-your-github-pages-site
I think we should approach it this way:
https://echo.labstack.com/
and commitThen let's proceed that way.
@lammel seems to be working http://labstack.github.io/echox/
Looks good!
@vishr We either move to https://labstack.github.io/echox/ or you update DNS for echo.labstack.com according to https://docs.github.com/en/github/working-with-github-pages/managing-a-custom-domain-for-your-github-pages-site (basically change to CNAME to labstack.github.ui). I'd prefer to keep the current domain for docs, as the search engines know these already.
@aldas @lammel I am working on this. Looks like CNAME was used in the past and now I am getting error during setup. Have opened a ticket with GitHub - waiting on it...
@vishr there is one step that needs to be done after CNAME
is set.
needs to be changed to export BASE_URL=https://echo.labstack.com/
CNAME was released, the website is now served by GitHub pages.
Thanks Guys @aldas @lammel
Will do a virtual meeting one day 🍺
Commit history is a mess but should be OK when merge is done with squash.
This adds support to serve documentation from github pages
To enable pages:
Settings
from top menuGitHub Pages
Source
choosegh-pages
and/ (root)
NB: actions need to be commited atleast once to master before. Then on next commit to master publishing will happen automatically
For example my fork is served here: https://aldas.github.io/echox/
Additional changes: