search

labstack / gommon

Common packages for Go
MIT License
536 stars 100 forks source link

Upgrade isatty to v0.0.8 #31

Closed wingyplus closed 5 years ago

wingyplus commented 5 years ago

gommon cannot run on https://play.golang.org because of using old isatty version. From https://github.com/mattn/go-isatty/issues/36, the author of isatty fixed in v0.0.8. So just upgrade it should work as expected.

codecov-io commented 5 years ago

Codecov Report

Merging #31 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #31   +/-   ##
=======================================
  Coverage   58.88%   58.88%           
=======================================
  Files           6        6           
  Lines         518      518           
=======================================
  Hits          305      305           
  Misses        210      210           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 82ef680...60e2066. Read the comment docs.

vishr commented 5 years ago

@wingyplus Do you mind fixing the conflict?

wingyplus commented 5 years ago

Thanks for your help @vishr