Closed StevenShofner closed 6 years ago
tstenner
commented
6 years ago I've disabled the Linux builds because Boost 1.66 isn't in the latest Ubuntu LTS (yet) and Travis doesn't want to upload the OS X binaries, but at least the Windows build worked.
StevenShofner
commented
6 years ago I just tested building this on Ubuntu 18.04 using Boost 1.65, and it works without issue. Would you like me to change the CMakeLists.txt to target 1.65 and unbreak Ubuntu?
tstenner
commented
6 years ago Nice, I missed the #if BOOST_VERSION. In that case we don't need a minimum Boost version because all platforms with a c++14 capable compiler should have a modern enough Boost version.
StevenShofner
commented
5 years ago Hi Tristan,
If you recall, I made some changes the App-EGIAmpServer to support currently released versions of the NA400 firmware and the new packet structure. I was preparing to show these changes to some colleagues and downloaded the 1.12.0 release. I notice that the interface is unchanged from the previous release, and wonder if there might have been some issue with the build?
I opened the source .ui file, and it looks correct (I’m attaching a screenshot of it).
On that note, I also see that the instructions for use are based on the previous interface. I would be happy to update these if necessary.
Thanks again for all of your help and guidance on this.
Steven Shofner
From: Tristan Stenner notifications@github.com Sent: Tuesday, November 6, 2018 9:13 AM To: labstreaminglayer/App-EGIAmpServer App-EGIAmpServer@noreply.github.com Cc: Shofner, Steven steven.shofner@philips.com; Author author@noreply.github.com Subject: Re: [labstreaminglayer/App-EGIAmpServer] Update to Allow Streaming from Current Generation NA 400 Amplifiers (#1)
Nice, I missed the #if BOOST_VERSION. In that case we don't need a minimum Boost version because all platforms with a c++14 capable compiler should have a modern enough Boost version.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flabstreaminglayer%2FApp-EGIAmpServer%2Fpull%2F1%23issuecomment-436332677&data=02%7C01%7C%7C87026b7cff9d4ded795c08d6440b1ee3%7C1a407a2d76754d178692b3ac285306e4%7C0%7C0%7C636771211882302570&sdata=jUsg5mbGyuPQZ5fv2%2BN3EPRzOD2bB368P2VZigdfl8c%3D&reserved=0, or mute the threadhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAqBmPUxZFepfyrsEs-69tKal_mEBLv4Cks5uscMigaJpZM4YPB-X&data=02%7C01%7C%7C87026b7cff9d4ded795c08d6440b1ee3%7C1a407a2d76754d178692b3ac285306e4%7C0%7C0%7C636771211882312583&sdata=RvndopgSh2I%2Fx0B3BOqLgyjr6Ecd2FAAPR1EWzise0U%3D&reserved=0.
The information contained in this message may be confidential and legally protected under applicable law. The message is intended solely for the addressee(s). If you are not the intended recipient, you are hereby notified that any use, forwarding, dissemination, or reproduction of this message is strictly prohibited and may be unlawful. If you are not the intended recipient, please contact the sender by return e-mail and destroy all copies of the original message.
StevenShofner
commented
5 years ago Hi Tristan,
I forgot to attach the screen shot.
Thanks.
Steven
From: Shofner, Steven Sent: Wednesday, February 6, 2019 9:07 AM To: labstreaminglayer/App-EGIAmpServer reply@reply.github.com Subject: RE: [labstreaminglayer/App-EGIAmpServer] Update to Allow Streaming from Current Generation NA 400 Amplifiers (#1)
Hi Tristan,
If you recall, I made some changes the App-EGIAmpServer to support currently released versions of the NA400 firmware and the new packet structure. I was preparing to show these changes to some colleagues and downloaded the 1.12.0 release. I notice that the interface is unchanged from the previous release, and wonder if there might have been some issue with the build?
I opened the source .ui file, and it looks correct (I’m attaching a screenshot of it).
On that note, I also see that the instructions for use are based on the previous interface. I would be happy to update these if necessary.
Thanks again for all of your help and guidance on this.
Steven Shofner
From: Tristan Stenner notifications@github.com<mailto:notifications@github.com> Sent: Tuesday, November 6, 2018 9:13 AM To: labstreaminglayer/App-EGIAmpServer App-EGIAmpServer@noreply.github.com<mailto:App-EGIAmpServer@noreply.github.com> Cc: Shofner, Steven steven.shofner@philips.com<mailto:steven.shofner@philips.com>; Author author@noreply.github.com<mailto:author@noreply.github.com> Subject: Re: [labstreaminglayer/App-EGIAmpServer] Update to Allow Streaming from Current Generation NA 400 Amplifiers (#1)
Nice, I missed the #if BOOST_VERSION. In that case we don't need a minimum Boost version because all platforms with a c++14 capable compiler should have a modern enough Boost version.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flabstreaminglayer%2FApp-EGIAmpServer%2Fpull%2F1%23issuecomment-436332677&data=02%7C01%7C%7C87026b7cff9d4ded795c08d6440b1ee3%7C1a407a2d76754d178692b3ac285306e4%7C0%7C0%7C636771211882302570&sdata=jUsg5mbGyuPQZ5fv2%2BN3EPRzOD2bB368P2VZigdfl8c%3D&reserved=0, or mute the threadhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAqBmPUxZFepfyrsEs-69tKal_mEBLv4Cks5uscMigaJpZM4YPB-X&data=02%7C01%7C%7C87026b7cff9d4ded795c08d6440b1ee3%7C1a407a2d76754d178692b3ac285306e4%7C0%7C0%7C636771211882312583&sdata=RvndopgSh2I%2Fx0B3BOqLgyjr6Ecd2FAAPR1EWzise0U%3D&reserved=0.
The information contained in this message may be confidential and legally protected under applicable law. The message is intended solely for the addressee(s). If you are not the intended recipient, you are hereby notified that any use, forwarding, dissemination, or reproduction of this message is strictly prohibited and may be unlawful. If you are not the intended recipient, please contact the sender by return e-mail and destroy all copies of the original message.
tstenner
commented
5 years ago I've reuploaded the CI build against the latest LSL, please check if that's the one you need.
StevenShofner
commented
5 years ago That’s it. Thank you!
From: Tristan Stenner notifications@github.com Sent: Thursday, February 7, 2019 2:35 AM To: labstreaminglayer/App-EGIAmpServer App-EGIAmpServer@noreply.github.com Cc: Shofner, Steven steven.shofner@philips.com; Author author@noreply.github.com Subject: Re: [labstreaminglayer/App-EGIAmpServer] Update to Allow Streaming from Current Generation NA 400 Amplifiers (#1)
I've reuploaded the CI build against the latest LSL, please check if that's the one you need.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Flabstreaminglayer%2FApp-EGIAmpServer%2Fpull%2F1%23issuecomment-461367368&data=02%7C01%7C%7Cb49cc28d94f74f037cb608d68ce7e5fe%7C1a407a2d76754d178692b3ac285306e4%7C0%7C0%7C636851324953683195&sdata=ycT8mW9lHuhcTlbq4liuUEgHnj2OC%2FnzyXuNuX2Q6Us%3D&reserved=0, or mute the threadhttps://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAqBmPasjdtKJXwjiHZcksuWipLFFLmU6ks5vLAFNgaJpZM4YPB-X&data=02%7C01%7C%7Cb49cc28d94f74f037cb608d68ce7e5fe%7C1a407a2d76754d178692b3ac285306e4%7C0%7C0%7C636851324953683195&sdata=os%2B2mzc8IwrRNkinbuc%2FCoHq9qaUZQiDQKuSh%2FxSQrQ%3D&reserved=0.
The information contained in this message may be confidential and legally protected under applicable law. The message is intended solely for the addressee(s). If you are not the intended recipient, you are hereby notified that any use, forwarding, dissemination, or reproduction of this message is strictly prohibited and may be unlawful. If you are not the intended recipient, please contact the sender by return e-mail and destroy all copies of the original message.
This update addresses remaining concerns expressed in the pull request to labstreaminglayer.
Makes compiler definitions BOOST_DATE_TIME_NO_LIB BOOST_REGEX_NO_LIB private to the project. Defines a macro dependent upon the Boost version to call the stream expires_from_now method with the appropriate data type. Uses std::strings rather than c strings in QString initializations. Updates the regex code to utilize raw string literals to simplify and improve readability.