labstreaminglayer / App-LabRecorder

An application for streaming one or more LSL streams to disk in XDF file format.
MIT License
125 stars 45 forks source link

Multiple streams with same name #99

Open crell-ine opened 1 year ago

crell-ine commented 1 year ago

Hello all,

we are currently trying to record streams from two instances of a software (BrainVision RDA) running on two different PCs. Since the stream names and IDs are fixed by the software, the only way to differentiate the streams is their hostname. In the latest release (1.16.4) of the LabRecorder, it is not possible to record both streams at the same time since only one of them is resolved (probably due to same name/id). In the 1.12 version, it was still possible to record both streams at the same time when the hostname was different. Would it be possible to include the hostname again for resolving streams?

Thank you in advance!

cboulay commented 1 year ago

In mainwindow.cpp MainWindow::refreshStreams there are several lines where it does comparisons to see if a stream is already known. e.g.: known |= s.name() == k.name && s.type() == k.type && s.source_id() == k.id;

Can you please try modifying these lines to add a hostname check? e.g., append && s.hostname() == k.host to the line above. From a quick glance, it looks like the lines that need to be modified are 303, 329, 361.