Find library in env, package, then system

labstreaminglayer / pylsl

Python bindings (pylsl) for liblsl

MIT License

136 stars 57 forks source link

Find library in env, package, then system #38

Closed agricolab closed 3 years ago

agricolab commented 3 years ago

Fix #37 Add docstring and documentation to find_liblsl_libraries Change search order, first go through prefix, suffix, and bitness locally then system-wide

agricolab commented 3 years ago

Sorry, i just saw that my visual code black autoformatter formatted it heavily. Give me a shout if you want that undone, @cboulay and i can open the PR fresh.

cboulay commented 3 years ago

I don’t mind the reformatting but can you separate it into another commit please?

agricolab commented 3 years ago

Okay, done. I added also

Fix a bug in the raise RunTimeError, as + were missing to join the multilinestrings
Catch PYLSL_LIB pointing towards a non-existent file.

Sorry for the many force-pushes, apparently even my gedit was removing trailing whitespace which resulted in too many diffs. I guess it is really time to format pylsl.py. Most recent tip is https://github.com/labstreaminglayer/liblsl-Python/commit/ba94136aa905e7cab8efdd3e12d7758083adcb83

cboulay commented 3 years ago

Sorry I took so long to get to this. It has been manually merged into master.

agricolab commented 3 years ago

No sweat. Happy if i could help.