search

labsyspharm / quantification

Quantification module for mcmicro
https://github.com/labsyspharm/mcmicro
9 stars 13 forks source link

Channels with the same name handling #12

Closed DenisSch closed 4 years ago

DenisSch commented 4 years ago

@JoshuaHess12 What happens exactly if two marker names are identical? Can we add a unique number (position in marker table) so they don't get removed.

JoshuaHess12 commented 4 years ago

Right now the marker names are getting cut off because they are stored in a python dictionary with the same keys if they have the same name. Would you want to add a suffix/counter to the end of names or have the original names instead with only different positions? For example, have a suffix for each (Hoechst_1, Hoechst_2)? Or keep the original name with a different column in the resulting csv file?

On Mon, Apr 6, 2020 at 12:30 PM DenisSch notifications@github.com wrote:

@JoshuaHess12 https://github.com/JoshuaHess12 What happens exactly if two marker names are identical? Can we add a unique number (position in marker table) so they don't get removed.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/labsyspharm/quantification/issues/12, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALCXKJDGNCC7XG733JEKE73RLH7SHANCNFSM4MCNLJFQ .

DenisSch commented 4 years ago

I would prefer HOECHST_1 etc

DenisSch commented 4 years ago

Tested - works great! Thank you!