labsyspharm / quantification

Quantification module for mcmicro
https://github.com/labsyspharm/mcmicro
9 stars 13 forks source link

Enable "minimal" and "full" CSV loading #14

Closed DenisSch closed 4 years ago

DenisSch commented 4 years ago

@JoshuaHess12 Do you have an idea how to enable the minimal loading (where only a list of names is provided) if the full CSV (which I have implemented now in 1.2.0) fails. That would enable backwards compatibility.

JoshuaHess12 commented 4 years ago

@DenisSch we could possibly include a small check after loading the csv file to see if the columns headers match the CyCIF pipeline csv structure (which you have implemented just now), and if they don't then we could assume that the csv structure is a single-column csv with the only column being the one used to indicate marker names (titled "marker_name"). How does this sound? For example, check if the pandas data frame contains the column titled "marker_name" and "cycle_number", and if it does then great it will be a CyCIF structured channel list -- otherwise we can assume the only important column is the "marker_name".

DenisSch commented 4 years ago

That’s sounds exactly what we need.

On Wed, Apr 8, 2020 at 16:55 JoshuaHess12 notifications@github.com wrote:

@DenisSch https://github.com/DenisSch we could possibly include a small check after loading the csv file to see if the columns headers match the CyCIF pipeline csv structure (which you have implemented just now), and if they don't then we could assume that the csv structure is a single-column csv with the only column being the one used to indicate marker names (titled "marker_name"). How does this sound? For example, check if the pandas data frame contains the column titled "marker_name" and "cycle_number", and if it does then great it will be a CyCIF structured channel list -- otherwise we can assume the only important column is the "marker_name".

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/labsyspharm/quantification/issues/14#issuecomment-611189610, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABVPRBPAYUI7WONBQ2PRPLDRLTQDVANCNFSM4MEGFRSA .

DenisSch commented 4 years ago

Adressed by 1.2.1