OSD Improvements #2

[johanmalm]

This relates to #879 #893 - but I'm just creating a new issue so that I can control the original post.

• [x] item height based on font height #893
• [x] window switcher width #893
• [x] item vertical padding #893
• [x] focused item border width #970
• [x] window-switcher padding #970
• [x] possible to hide each of 3 columns
• [x] size of the squares in desktop switcher (with osd.workspace-switcher.boxes.width/height)
• [x] osd.c: simplify the get_title() helper and associated is_title_different()
• [x] Show always on-top windows in window-switcher
• [x] Consider showing multiple work-spaces in window-switcher
• [ ] focused item background and text color
• [ ] position of desktop name (top/bottom)
• [ ] different font size for desktop switcher and window switcher
• [ ] Consider allowing window-switcher width to be specified as a percentage of output width
• [ ] Cope with nr_items * item_height > output_height
• [ ] Consider grouping by workspace in window-switcher
• [ ] Consider showing window thumbnails

[Consolatis]

focused item border width doesn't seem to be implemented?

[stefonarch]

I'll drop just my 2 cents here: I do not much like the square border of the selected item - why not use the same hover color as in window title menu's selected items? Or an option to disable for it?

[Consolatis]

We can allow for that when the three new theme vars are implemented:

• focused.border.width: 0 (or focused.thickness or whatever naming we come up with)
• focused.bg.color: #whatever
• focused.text.color: #whatever

[droc12345]

Consider showing multiple work-spaces in window-switcher

should be checked?

[Consolatis]

Consider showing multiple work-spaces in window-switcher

should be checked?

Thanks, checked and added a new Consider grouping by workspace in window-switcher. (Also reordered the list so the checked items are on top to easier see what is still open.)

[droc12345]

Consolatis, did you want me to fix the rest of the custom config for window switcher? I think basically it needs doc (which I don't have a problem doing) and removing a few things from your patch that have already been applied to labwc, ie repackage what you have in the patch. I know you pointed to a few possible enhancements/fixes, but those could be done after merge as fine tuning the code.

I've been using it as my daily way to use window switcher, been working well. Putting it in would allow others to start testing it also.

[Consolatis]

Consolatis, did you want me to fix the rest of the custom config for window switcher? I think basically it needs doc (which I don't have a problem doing) and removing a few things from your patch that have already been applied to labwc, ie repackage what you have in the patch.

If you have the time and motivation to do so, feel free :) Got side tracked, too many things to work on simultaneously.

[droc12345]

I knew you were busy, thus the offer

1654

[Vladimir-csp]

Please also consider adding ability to theme window focus highlight frame, potentially into something other than 3-pixel 2-color frame.